[Webkit-unassigned] [Bug 49791] [GTK] Implement SharedMemory for WebKit2

Sat Feb 5 05:54:25 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=49791

--- Comment #20 from Amruth Raj <amruthraj at motorola.com>  2011-02-05 05:54:25 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > (In reply to comment #17)
> >
> > [...]
> >
> > > Are you working on this? I have Amruth shared memory patch working with gtk and I was wondering if it made sense to try to land it or wait for this, or help implementing it.
> > 
> > I'm not sure who you're asking, I at least am not working on this at the moment..
> 
> Yep, it was you and Amruth, thanks for commenting. Kphrane told me yesterday in the IRC that Amruth is working on it.
> 
> Last days I updated all the Minibrowser patches (bug 52805) to compile and work with current HEAD and with gtk2 and gtk3 (I used sharedmemory for gtk3 to avoid gdkpixmaps), so my plan would be to upload all of them with all these changes considering this one is solved (until we know how long it will take to finish the unix solution). With all these patches uploaded we could start working in the gtk webkit2 more easily without blocking, Does that sound good to everybody?

This sounds great. The basic implementation that I've put up here works, but we definitely need to address the drawbacks mentioned in bug 51984, like passing fd's instead of filenames etc. This needs a good amount of code change for files that are already checked-in as well(for eg. Connection class, ProcessLauncher class etc.). 
Now that you have a patch based on HEAD, it's better we go ahead with all these. Meanwhile I'll create a separate bug for making the patch at 51984 generic and get it accepted by reviewers from both QT and GTK.
I'm glad that you've retained the GdkPixmap based solution for GTK2 ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.