[Webkit-unassigned] [Bug 52819] Crash in WebCore::HistoryController::itemsAreClones

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52819


Mihai Parparita <mihaip at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81128|review?                     |review+
               Flag|                            |




--- Comment #28 from Mihai Parparita <mihaip at chromium.org>  2011-02-04 13:45:30 PST ---
(From update of attachment 81128)
View in context: https://bugs.webkit.org/attachment.cgi?id=81128&action=review

> LayoutTests/fast/history/history-back-forward-within-subframe-hash.html:3
> +onload = function() {

Nit: There isn't a formal style guide for JavaScript used in layout tests, but generally the convention is to follow the WebKit C++ style (four space indents, function braces on their own line).

> LayoutTests/fast/history/resources/history-back-forward-within-subframe-hash-2.html:15
> +      parent.document.getElementById("result").innerText = "First visit";

If you use the js-test framework (see same-document-iframes-changing-fragment.html, history-traversal-is-asynchronous.html, and a few other tests in the directory), then you can turn these into log statements instead of replacing the result text. That makes failures easier to debug, since you can more clearly see at what stage the actual output started to deviate from the expected one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.