[Webkit-unassigned] [Bug 53722] Hook up WebGraphicsContext3D::setContextLostCallback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53722


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81163|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2011-02-04 13:20:26 PST ---
(From update of attachment 81163)
View in context: https://bugs.webkit.org/attachment.cgi?id=81163&action=review

Looks good overall. r- for the minor issue of the naked new which needs to be cleaned up. One question.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:378
> +    m_context->setContextLostCallback(new WebGLRenderingContextLostCallback(this));

naked new. Should use adoptPtr(new ...);

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:1110
> +    m_impl->setContextLostCallback(m_contextLostCallbackAdapter.get());

Is there an ownership issue here? Does the WebGraphicsContext3D take ownership of the passed callback like GraphicsContext3D and WebGLRenderingContext or not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.