[Webkit-unassigned] [Bug 51013] [Chromium] Should implement EditorClientImpl::requestCheckingOfString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51013


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81182|review?                     |review-
               Flag|                            |




--- Comment #29 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-04 10:37:52 PST ---
(From update of attachment 81182)
View in context: https://bugs.webkit.org/attachment.cgi?id=81182&action=review

> Source/WebKit/chromium/public/WebTextCheckingCompletion.h:35
> +#include "WebTextCheckingResult.h"

nit: i think you can just forward declare WebTextCheckingResult and WebVector here instead.

> Source/WebKit/chromium/public/WebTextCheckingResult.h:35
> +#include "WebVector.h"

nit: no need for WebVector include here

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:232
> +    WebViewHost* wvh = static_cast<WebViewHost*>(context);

how do you know that the WebViewHost hasn't been deleted by the time this function is called?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.