[Webkit-unassigned] [Bug 52997] [GTK] DRT's TextInputController is unimplemented on GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52997





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-02-04 05:24:24 PST ---
(In reply to comment #3)
> (From update of attachment 80443 [details])
> If possible I think I'd either like to see this touch the GtkIMContext of the WebView either here or below. That way this will also test the WebKit layer.

The problem is that it's not always possible to use the im-context, see below

> > Tools/DumpRenderTree/gtk/TextInputController.cpp:65
> > +    g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context));
> > +
> > +    DumpRenderTreeSupportGtk::setComposition(view, stringBuffer.get(), start, end);
> > +
> > +    return JSValueMakeUndefined(context);
> 
> Can you just use the im-context property from the WebView and emit the preedit-changed signal?

preedit-changed callback doesn't receive the start and end, so setComposition() is always called with 0, 0

frame->editor()->setComposition(preeditString, underlines, 0, 0);

> Is it possible just to get the im-context via the im-context property on the WebView and then emit the "commit" signal?

in this case it would probably be possible, but I'm not sure it makes sense to use it only in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.