[Webkit-unassigned] [Bug 53756] Refactor and/or split and/or rename the extend-selection tests to be clearer what they're doing, and able to be run manually

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 22:20:09 PST 2011


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #81186|review?                     |review-
               Flag|                            |

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-03 22:20:10 PST ---
(From update of attachment 81186)
Making tests manually runnable is good but all these rewrites of script isn't that great.  It's really hard to see that new tests are testing the same things the old tests were testing.  In general, we must be careful when modifying tests because subtle differences may affect what tests do.  At least, we should separate refactoring and changes to make it manually runnable.

I don't think separating the line boundary tests into LTR/RTL tests is a good idea because having both results on one test has helped us catching regressions in either result since extend-selection-* tests are written so that LTR/RTL results should match.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list