[Webkit-unassigned] [Bug 52594] Move chromium iframe shim code to cross-platform file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52594


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81107|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #16 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-03 13:58:28 PST ---
(From update of attachment 81107)
View in context: https://bugs.webkit.org/attachment.cgi?id=81107&action=review

Looks good, just one remaining nit.  R=me w/ that resolved.

> Source/WebCore/plugins/IFrameShimSupport.h:30
> +void getPluginOcclusions(Element*, Widget* parentWidget, const IntRect& frameRect, Vector<IntRect>& cutOutRects);

nit-picky nit: rename |cutOutRects| to |occlusions| to be consistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.