[Webkit-unassigned] [Bug 53558] Make WebProcess pass explicit homedir parameter to the sandbox

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 12:53:13 PST 2011


--- Comment #7 from Ivan Krstić <ike at apple.com>  2011-02-03 12:53:13 PST ---
(From update of attachment 80866)
View in context: https://bugs.webkit.org/attachment.cgi?id=80866&action=review

>> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:130

> Isn't -fileSystemRepresentation more appropriate?

Not really. -fileSystemRepresentation is generally meant for normalizing programmatically-constructed paths, or making sure that derived paths remain correct during cross-volume operations. This line does neither.

>> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:142
>> +        "HOME_DIR", (const char*)homeRealPath,
> I'm surprised this cast is necessary.

It's not, but follows local style (see tmpRealPath, cacheRealPath below). We can eliminate all the casts in a separate patch if you'd like.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list