[Webkit-unassigned] [Bug 51331] [Qt] REGRESSION (r73535): tst_QWebPage fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51331





--- Comment #3 from Robert Hogan <robert at webkit.org>  2011-02-03 12:51:28 PST ---
(In reply to comment #2)
> (From update of attachment 79847 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79847&action=review
> 
> > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:512
> > -    QVERIFY(contextMenu);
> > +    QVERIFY(!contextMenu);
> >      delete contextMenu;
> 
> Deleting a null pointer is incorrect. Otherwise it worked for me locally.

Good point, though see https://bugs.webkit.org/show_bug.cgi?id=20357

The test is ensuring that contextMenu is a protected pointer. So attempting to delete it still tests that, I think. Could be confused though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.