[Webkit-unassigned] [Bug 53707] New: Viewport Warning/Error Messages Are Now Inaccurate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53707

           Summary: Viewport Warning/Error Messages Are Now Inaccurate
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: ddkilzer at webkit.org, kenneth at webkit.org


The changes to the ViewportArguments implementation did not update the error messages
accordingly, so they either no longer make sense or are inaccurate.

The new implementation landed in r67376:
http://trac.webkit.org/changeset/67376

It follows the "css-viewport" spec:
http://people.opera.com/rune/TR/css-viewport/#parsing-algorithm

Example situations:

1. <meta name="viewport" content="width=nothing">

  Actual Result   => Viewport argument "width" not recognized. Content ignored.
  Expected Result => Viewport argument value for "width" not recognized. Value ignored.

2. <meta name="viewport" content="width=1.0x">

  Actual Result   => Viewport argument "width" not recognized. Content ignored.
  Expected Result => Viewport argument value for "width" was truncated from "1.0x" to "1.0".

3. <meta name="viewport" content="width=101">
   NOTE: With a device width that is NOT 101.
   NOTE: The same applies for height.

  Actual Result   => Viewport width or height set to physical device width, try using "device-width" constant instead for future compatibility.
  Expected Result => No warning, or a suggestion to use appropriate constants.
                  => The "device-width" / "device-height" message should only happen when the constant is equal to the device width/height.

4. Inconsistent spacing in Error messages:

  Two spaces after period => "Viewport argument \"%replacement\" not recognized. Content ignored."
  One space  after period => "Viewport maximum-scale cannot be larger than 10.0.  The maximum-scale will be set to 10.0."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.