[Webkit-unassigned] [Bug 52296] [Qt]Add local storage settings to QtTestBrowser option menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52296


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81067|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #13 from Andreas Kling <kling at webkit.org>  2011-02-03 09:12:21 PST ---
(From update of attachment 81067)
View in context: https://bugs.webkit.org/attachment.cgi?id=81067&action=review

Much better, some small things remaining:

> Tools/QtTestBrowser/launcherwindow.cpp:923
> +            page()->settings()->setOfflineStorageDefaultQuota(quotaSize);       

What if 'quotaSize' is negative?

> Tools/QtTestBrowser/launcherwindow.cpp:924
> +        }

This } is wrongly indented.

> Tools/QtTestBrowser/main.cpp:177
>          int maxSize = takeOptionValue(&args, setOfflineStorageDefaultQuotaIndex).toInt();

'maxSize' should be of an unsigned type, to match WindowOptions::offlineStorageDefaultQuotaSize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.