[Webkit-unassigned] [Bug 50624] [GTK] Don't use a fixed size for search field icons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50624


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79910|review?                     |review+
               Flag|                            |




--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2011-02-03 08:35:22 PST ---
(From update of attachment 79910)
View in context: https://bugs.webkit.org/attachment.cgi?id=79910&action=review

Okay! This should land with new DRT dumps / pixel results (for GTK+ 2.x).

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:252
> +static GtkIconSize getIconSizeForPixelSize(gint pixelSize)

I think it's more appropriate to use int instead of gint.

> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:284
> +    gint fontSize = style->fontSize();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.