[Webkit-unassigned] [Bug 53213] Refactoring: Extract TextCheckerClient from EditorClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 06:31:01 PST 2011


--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-03 06:31:00 PST ---
(From update of attachment 80314)
View in context: https://bugs.webkit.org/attachment.cgi?id=80314&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22447
> +				A7151BD812F1558F005A0F64 /* TextCheckerClient.h in Headers */,

You should put this in the right lexicological order.

> Source/WebCore/loader/EmptyClients.h:396
> -class EmptyEditorClient : public EditorClient {
> +class EmptyEditorClient : public EditorClient, public TextCheckerClient {

I'm not sure if EmptyEditorClient should be both EditorClient and TextCheckerClient.  I think we should have a separate EmptyTextCheckerClient.

> Source/WebCore/page/EditorClient.h:73
> +class TextCheckerClient;

Huh, shouldn't T come before V?

> Source/WebCore/page/EditorClient.h:163
> +    virtual TextCheckerClient* textChecker() = 0;

Is it common for a client to return another client?  If not, we should probably add textCheckingClient() to Editor, and let Page return TextCheckerClient.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list