[Webkit-unassigned] [Bug 53213] Refactoring: Extract TextCheckerClient from EditorClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 3 00:37:48 PST 2011


--- Comment #16 from MORITA Hajime <morrita at google.com>  2011-02-03 00:37:47 PST ---
Hi Ryosuke, thank you for your response!

> > Source/WebCore/page/EditorClient.h:174
> >      virtual void updateSpellingUIWithMisspelledWord(const String&) = 0;
> >      virtual void showSpellingUI(bool show) = 0;
> >      virtual bool spellingUIIsShowing() = 0;
> Why are these methods not moved?  I'm having a trouble knowing what's the boundary between TextCheckingClient and EditorClient.  Could you clarify what you're trying to accomplish here?

TextCheckingClient is for abstracting out spell-checking backends like Hunspell, not for controlling GUI.
Because methods above are for controlling, GUI (pop up, etc), I left them on EditorClient.

 I assume that Spell-checkers have non-GUI backends, For Hunspell this is true.
NSSpellChecker is also separating its Panel UI to NSPanell instance (NSSpellChecker::spellingPanel).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list