[Webkit-unassigned] [Bug 53583] Refactoring: <progress> should not use ShadowElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53583





--- Comment #8 from MORITA Hajime <morrita at google.com>  2011-02-02 21:59:56 PST ---
Dimitori, thank you for the review!
I updated the patch.

(In reply to comment #4)
> (From update of attachment 80908 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80908&action=review
> 
> Can you explain a bit about the originalVisibility? I may have known but forgotten, and now confuses me. I am easily confused. Why do we need this?
This is for the situation that dynamically changes the visibility. (hiding/unhiding the part element.)
Though <progress> has no such case,  <meter> has one.
I'm preparing for code sharing between <meter>and <progress>, so I'll put this here.

> 
> > Source/WebCore/html/HTMLProgressElement.cpp:40
> > +class ProgressBarValueElement : public HTMLDivElement {
> 
> This class should live in html/shadow/ProgressBarValuePartElement
Moved to there.

> 
> > Source/WebCore/html/HTMLProgressElement.cpp:53
> > +#if 0
> 
> You didn't mean to leave this in :)
>
Oops. Removed.

> > Source/WebCore/rendering/RenderIndicator.h:37
> > +    virtual bool shouldHidden() = 0;
> 
> shouldBeHidden()?
Sure. Renamed.

> 
> > Source/WebCore/rendering/RenderProgress.cpp:102
> > +    for (RenderObject* child = firstChild(); child; child = child->nextSibling())
> 
> Why is this here? Why can't we just use RenderProgress:layout()?
This is because RenderProgress shares layout() with RenderMeter via RenderIndicator superclass.
I'm going to migrate the layout code of both and remove layoutAsPart() at that change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.