[Webkit-unassigned] [Bug 53564] Make canHaveChildrenForEditing more efficient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 16:17:39 PST 2011


--- Comment #6 from Eric Seidel <eric at webkit.org>  2011-02-02 16:17:39 PST ---
(From update of attachment 80996)
View in context: https://bugs.webkit.org/attachment.cgi?id=80996&action=review

It kinda sucks to polute Node.h like this.  I mean, certainly we follow this pattern for other areas of the code, but I wonder if in this case your original hashset isn't better?   Are there more general rules about what types of tags can/can't have editing kids?  should we move the false up to some PluginElement superclass instead of <object>, <embed> directly?

> Source/WebCore/dom/Node.h:234
> +    // FIXME: We should return false here and return true in ContainerNode
> +    virtual bool canHaveChildrenForEditing() const { return true; }

Why not just fix this?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list