[Webkit-unassigned] [Bug 52509] Shadow is not shown when using strokeRect with a gradient strokeStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52509





--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-02-02 16:11:08 PST ---
(From update of attachment 80979)
View in context: https://bugs.webkit.org/attachment.cgi?id=80979&action=review

> LayoutTests/svg/css/text-gradient-stroke-shadow.svg:8
> +<text x="100" y="300" style="font-size: 300px; text-shadow: #000 20px 20px 20px;" stroke-width="10" stroke="url(#gradient)">SVG</text>

Maybe just use a rect in these tests to avoid font differences between platforms.

Why does Mac render hollow characters, but the other platforms render solid black ones?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:972
> +            const float halfLineWidth = lineWidth / 2;

Can you add a comment explaining the lineWidth/2 offset? Why do it here, and not in the non-shadow path?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1000
>  
> +

New blank line here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.