[Webkit-unassigned] [Bug 52594] Move chromium iframe shim code to cross-platform file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52594





--- Comment #14 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-02 14:58:12 PST ---
(From update of attachment 80973)
View in context: https://bugs.webkit.org/attachment.cgi?id=80973&action=review

Sorry, just nit-picking wording at this point.  I hope you find this helpful :)

> Source/WebCore/plugins/IframeShimSupport.h:20
> +#ifndef IframeShimSupport_h

nit: IFrame* instead of Iframe* to match HTMLIFrameElement.h ?

> Source/WebCore/plugins/IframeShimSupport.h:30
> +void windowRectsPluginShouldNotPaintOver(Element*, Widget* parentWidget, const IntRect& frameRect, Vector<IntRect>& cutOutRects);

it might work nicely to use the term "occlusions" here.  the plugin is occluded by iframes on the page.

  {compute,calculate,get}PluginOcclusions

I think the Chromium code is using the term "cut-outs" in the same way that I'm trying to use occlusions.  I suppose you could also use the term "clip" here.

  {compute,calculate,get}PluginClipRects

These seem to say the same thing as "window rects the plugin should not paint over" and are a bit shorter and in the case of "clip rects" more canonical?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.