[Webkit-unassigned] [Bug 51013] [Chromium] Should implement EditorClientImpl::requestCheckingOfString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51013





--- Comment #22 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-02 13:14:57 PST ---
(In reply to comment #16)
> > so, going with that model, you'd end up with an API that might look like:
> > 
> >   WebViewClient::requestTextCheck(const WebString&, WebTextCheckCompletion*)
> This makes sense. But in this case, async spellcheck will cross the process boundary 
> and the pointer-as-an-identifier approach doesn't look better than the plain identifier.
> I'd like to keep current design.

Well, I think that our WebKit API should not have baked in assumptions about being used in a multi-process browser.  It seems like you could just as easily put the map from identifier to WebTextCheckCompletion* outside in Chromium instead of within WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.