[Webkit-unassigned] [Bug 50885] [GTK] remove old data: URI handler, fix the SoupRequest-based one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50885


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80575|review?                     |review-
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-02-02 12:45:01 PST ---
(From update of attachment 80575)
View in context: https://bugs.webkit.org/attachment.cgi?id=80575&action=review

This looks very good, but I have a few mostly stylistic suggestions.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:132
> +static bool startGeneric(ResourceHandle*, KURL);

I think the startHttp/startGeneric pair should probably be called startHTTPRequest and startNonHTTPRequest for the sake of explicitness and the WebKit style guidelines.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:470
> +        String mimeType = extractMIMETypeFromMediaType(contentType);
> +        String charset = extractCharsetFromMediaType(contentType);
> +        d->m_response.setMimeType(mimeType);
> +        d->m_response.setTextEncodingName(charset);

If possible, please just make this:

d->m_response.setMimeType(extractMIMETypeFromMediaType(contentType));
d->m_response.setTextEncodingName(extractCharsetFromMediaType(contentType));

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:-902
> -    // GIO doesn't know how to handle refs and queries, so remove them
> -    // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are
> -    // using GIO internally, and providing URIs instead of file paths
> -    url.removeFragmentIdentifier();
> -    url.setQuery(String());
> -    url.removePort();

Do you mind explaining this removal in the startNonHTTP (nee startGeneric) section of the ChangeLog?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.