[Webkit-unassigned] [Bug 52594] Move chromium iframe shim code to cross-platform file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 12:35:59 PST 2011


--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-02 12:35:58 PST ---
(In reply to comment #9)
> (In reply to comment #6)
> > Yeah, this is what I was suggesting we do.  Maybe the file could be more specifically named... IFrameShimSupport.{h,cpp}?  That's not the best name either :-P
> Both names suck, so I chose mine! Please r- if you think a file that can take future cross-platform utility functions is a bad idea.

In general, WebCore seems to frown at giving files a "utility" style name as that suggests a future dumping ground.  Instead, if we can use a more specific name, then people won't be tempted to turn this file into a dumping ground.  Implicit in that argument is that dumping grounds are bad :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list