[Webkit-unassigned] [Bug 53529] [fileapi] Add support for filesystem: URI handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53529





--- Comment #15 from Adam Klein <adamk at chromium.org>  2011-02-02 09:42:49 PST ---
(From update of attachment 80867)
View in context: https://bugs.webkit.org/attachment.cgi?id=80867&action=review

>> Source/WebCore/fileapi/Entry.cpp:95
>> +    return uri;
> 
> Consider using StringBuilder instead of +=.  That should save a bunch of allocations.

Done. I was thinking std::string, now I know how to treat WTF::String.

>> Source/WebCore/page/SecurityOrigin.cpp:85
>> +        if (originURL.isValid()) {
> 
> If the originURL isn't valid, will we trigger the "m_isUnique = true" assignment on line 95?  If not, we should probably do that explicitly.

Added my own explicit setting in the else branch (the other one wasn't going to trigger).

>> Source/WebCore/page/SecurityOrigin.cpp:88
>> +            m_port = originURL.port();
> 
> Do we need to do something with default ports, or will that happen automagically for us?

That'll be handled by the last if statement in the constructor.  It worries me a little that the ordering is so important here, but it's still short enough to fit on one screen.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.