[Webkit-unassigned] [Bug 53583] Refactoring: <progress> should not use ShadowElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53583


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80908|review?                     |review-
               Flag|                            |




--- Comment #4 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-02-02 09:21:26 PST ---
(From update of attachment 80908)
View in context: https://bugs.webkit.org/attachment.cgi?id=80908&action=review

Can you explain a bit about the originalVisibility? I may have known but forgotten, and now confuses me. I am easily confused. Why do we need this?

> Source/WebCore/html/HTMLProgressElement.cpp:40
> +class ProgressBarValueElement : public HTMLDivElement {

This class should live in html/shadow/ProgressBarValuePartElement

> Source/WebCore/html/HTMLProgressElement.cpp:53
> +#if 0

You didn't mean to leave this in :)

> Source/WebCore/rendering/RenderIndicator.h:37
> +    virtual bool shouldHidden() = 0;

shouldBeHidden()?

> Source/WebCore/rendering/RenderProgress.cpp:102
> +    for (RenderObject* child = firstChild(); child; child = child->nextSibling())

Why is this here? Why can't we just use RenderProgress:layout()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.