[Webkit-unassigned] [Bug 53497] Web Inspector: do not hide scope variables with command line api.

Tue Feb 1 23:41:06 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53497

--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2011-02-01 23:41:06 PST ---
(In reply to comment #1)
> So, with (a), you won't get the command line api at a breakpoint, but you will get it when you're NOT stopped at a breakpoint.  Seems confusing.  
> 
> Can we query the scope and only expose properties that won't shadow something on the stack?
> 
> In any case, it seems like having all the API in an object like "console" would be a nice capability, that we could support no matter what else we do?
> 
> Wonder what FireBug does - they would at least have a problem of not making shadowable API available - if they don't have the same problem we do.  Would be nice to have both debuggers have the same capability (in terms of adding all the API to console, or whatever).

I think FireBug does not export Command line API while on a breakpoint. Anyways, I was going to remove our support for it, but you gave me an idea:
  When command line API is needed, before every evaluation on a callframe, go through the command line api properties (log, inspect, etc.) and hide the ones that match any of the scope roots (local, closures, with) or global object properties. It looks like it should work and should not be expensive: we already have scope roots, checking for ("log" in window) should not be bad either. It will still hide non-enumerable properties, but that should be fine (window.foo) will still work as a workaround.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.