[Webkit-unassigned] [Bug 53529] [fileapi] Add support for filesystem: URI handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53529





--- Comment #13 from Adam Barth <abarth at webkit.org>  2011-02-01 19:54:06 PST ---
(From update of attachment 80867)
View in context: https://bugs.webkit.org/attachment.cgi?id=80867&action=review

> Source/WebCore/fileapi/Entry.cpp:95
> +    String uri = "filesystem:";
> +    uri += filesystem()->scriptExecutionContext()->securityOrigin()->toString();
> +    uri += "/";
> +    uri += (m_fileSystem->asyncFileSystem()->type() == AsyncFileSystem::Temporary ? "temporary" : "persistent");
> +    uri += m_fullPath;
> +    return uri;

Consider using StringBuilder instead of +=.  That should save a bunch of allocations.

> Source/WebCore/page/SecurityOrigin.cpp:85
> +        if (originURL.isValid()) {

If the originURL isn't valid, will we trigger the "m_isUnique = true" assignment on line 95?  If not, we should probably do that explicitly.

> Source/WebCore/page/SecurityOrigin.cpp:88
> +            m_port = originURL.port();

Do we need to do something with default ports, or will that happen automagically for us?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.