[Webkit-unassigned] [Bug 52594] Copy chromium iframe shim code to PluginView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52594





--- Comment #6 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-01 14:11:04 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Isn't there some way we could put this into shared code?
> 
> See https://bugs.webkit.org/show_bug.cgi?id=28914#c9
> 
> AFAICT Chromium instantiates its own plugin objects and only uses PluginViewNone from the WebCore code.

I think we subclass PluginViewBase now.  See WebKit/chromium/src/WebPluginContainerImpl.{h,cpp}


> 
> The functions could be added as simple utility functions in a file PluginViewSupport.cpp and shared there. Would that be acceptable?

Yeah, this is what I was suggesting we do.  Maybe the file could be more specifically named... IFrameShimSupport.{h,cpp}?  That's not the best name either :-P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.