[Webkit-unassigned] [Bug 50916] Add support for dir=auto

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 12:20:11 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=50916





--- Comment #5 from Yael <yael.aharon at nokia.com>  2011-02-01 12:20:11 PST ---
(In reply to comment #3)
> (From update of attachment 80700 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80700&action=review
> 
> > Source/WebCore/html/HTMLElement.cpp:162
> > +        if (equalIgnoringCase(attr->value(), "auto"))
> > +            setHasDirAutoFlagRecursively(true);
> > +        else 
> > +            setHasDirAutoFlagRecursively(false);
> 
> It’s not clear to me how this won’t result in clearing the flag on descendants that have dir="auto" specified when the ancestor changes from "auto" to non-"auto".

You are right, we will lose the flag in that case. I'll update the patch to correct that.
thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list