[Webkit-unassigned] [Bug 53436] [Gtk] atk_text_get_caret_offset fails for list items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53436


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80659|0                           |1
        is obsolete|                            |
  Attachment #80766|                            |review?
               Flag|                            |




--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2011-02-01 09:15:29 PST ---
Created an attachment (id=80766)
 --> (https://bugs.webkit.org/attachment.cgi?id=80766&action=review)
Patch proposal + unit tests

(In reply to comment #3)
> (From update of attachment 80659 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80659&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        (webkit_accessible_text_get_caret_offset): Ajust the offset with
> 
> Should be "Adjust" here.

Fixed

> > Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1231
> > +        offset += g_utf8_strlen(markerText.utf8().data(), -1);
> 
> Unless I'm mistaken, if you want the offset in bytes, you should use strlen(markerText.utf8().data()) if you want the offset in characters you can just use markerText.length().

You're right. Thanks for noticing.

Fixed either there and in webkit_accessible_text_set_caret_offset (and updated the ChangeLog)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.