[Webkit-unassigned] [Bug 47700] Make mime type lookup in File::create(path) thread-safe

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 1 08:57:41 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=47700


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80710|review?                     |review-
               Flag|                            |




--- Comment #10 from David Levin <levin at chromium.org>  2011-02-01 08:57:40 PST ---
(From update of attachment 80710)
This looks good. One last thing to fix up wherever you added ASSERT(isMainThread()); please make sure that the file has the following includes:

#include <wtf/Assertions.h>
#include <wtf/MainThread.h>

I spot checked MIMETypeRegistryWinCE.cpp and MimeTypeRegistryWx.cpp and noticed they didn't have these so those builds may get broken by this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list