[Webkit-unassigned] [Bug 75397] MathML code clean-up

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 31 19:35:33 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=75397





--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2011-12-31 19:35:33 PST ---
(From update of attachment 120820)
View in context: https://bugs.webkit.org/attachment.cgi?id=120820&action=review

We don't usually land changes that only clean up style, unless they are really necessary for subsequent work. This just makes following svn blame harder.

> Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp:215
> -}    
> +} // namespace WebCore

This in particular is arguably a regression. There is no coding style rules that asks to comment closing braces, and I think that this just adds visual noise. If you suspect incorrect nesting, you are going to ask your editor to balance braces, not trust comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list