[Webkit-unassigned] [Bug 72801] Cannot print USPS shipping labels

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72801





--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-12-31 11:14:41 PST ---
(From update of attachment 120761)
View in context: https://bugs.webkit.org/attachment.cgi?id=120761&action=review

Looks great.

Does this depend on bug 75232?

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:838
> +    WebPage* page = frame->page();
> +    if (!page)

We have a check for pageless frame here, but not in BuiltInPDFView::initialize() or BuiltInPDFView::isActive(). Can page actually be null?

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:841
> +    page->sendSync(Messages::WebPageProxy::PrintFrame(frame->frameID()), Messages::WebPageProxy::PrintFrame::Reply());

I'd have routed this through WebCore, for instance to make use of PageGroupLoadDeferrer once Chrome::print starts using it.

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h:35
> +typedef const struct OpaqueJSContext* JSContextRef;
> +typedef struct OpaqueJSValue* JSObjectRef;
> +typedef const struct OpaqueJSValue* JSValueRef;

:(

> Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h:139
> -    virtual void disconnectFromPage() { m_page = 0; }
> +    virtual void disconnectFromPage() { m_frame = 0; }

This is now a little bit surprising.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.