[Webkit-unassigned] [Bug 75293] Use IDL overloads in AudioContext.idl for createBuffer in the case of V8 binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75293


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120642|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-12-28 11:20:33 PST ---
(From update of attachment 120642)
View in context: https://bugs.webkit.org/attachment.cgi?id=120642&action=review

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:128
> +                setDOMException(exec, ec);
>                  return throwError(exec, createSyntaxError(exec, "Error decoding audio file data"));

Aren't these redundant?

> Source/WebCore/webaudio/AudioContext.cpp:330
> +fail:
> +    ec = SYNTAX_ERR;
> +    return 0;

I would have just repeated these two lines rather than use goto.

> Source/WebCore/webaudio/AudioContext.idl:54
> +        // FIXME: Remove 'else' once JSC supports overloads too.

JSC doesn't support overloads?  I thought it did.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.