[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #20 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-12-27 20:40:32 PST ---
(From update of attachment 119559)
View in context: https://bugs.webkit.org/attachment.cgi?id=119559&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:67
> +        ewk_notification_request_permission(m_view, context->securityOrigin()->toString().utf8().data());

In GTK port, each file for independent feature has private data structure. The private structure has reference of webView.
webview interacts with independent feature via the private structure.

For example,

In ChromeClientGtk.cpp,

643 void ChromeClient::dispatchViewportPropertiesDidChange(const ViewportArguments& arguments) const
644 {
645     // Recompute the viewport attributes making it valid.
646     webkitViewportAttributesRecompute(webkit_web_view_get_viewport_attributes(m_webView));
647 }

In webkitviewportattributes.cpp

519 void webkitViewportAttributesRecompute(WebKitViewportAttributes* viewportAttributes)
520 {
521     WebKitViewportAttributesPrivate* priv = viewportAttributes->priv;
522     WebKitWebView* webView = priv->webView;
523 
524     IntRect windowRect(webView->priv->corePage->chrome()->windowRect());
525     priv->deviceWidth = windowRect.width();
526     priv->deviceHeight = windowRect.height();
527     



In webkitviewportattributesprivate.h,

 30 struct _WebKitViewportAttributesPrivate {
 31     WebKitWebView* webView;
 32     int deviceWidth;
 33     int deviceHeight;
 34     int availableWidth;
 35     int availableHeight;
 36     int desktopWidth;
 37     int deviceDPI;
 38     
 39     int width;
 40     int height;
 41     float initialScaleFactor;
 42     float minimumScaleFactor;
 43     float maximumScaleFactor;
 44     float devicePixelRatio;
 45     gboolean userScalable;
 46     gboolean isValid;
 47 };

In webkitviewportattributes.cpp, it uses webView instance via private structure. I think EFL port also needs to have similar structure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.