[Webkit-unassigned] [Bug 75243] [EFL] Refactor single backing store scroll code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75243


KwangHyuk <hyuki.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hyuki.kim at samsung.com




--- Comment #2 from KwangHyuk <hyuki.kim at samsung.com>  2011-12-27 06:13:28 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=120575&action=review

> Source/WebKit/efl/ewk/ewk_view_single.cpp:94
> +    uint32_t* endOfSource = source + (count - 1);

What about putting (count - 1) into another variable ?

> Source/WebKit/efl/ewk/ewk_view_single.cpp:104
> +    const bool moveLineLeft = sourceX >= destinationX ? true : false;

moveLineLeft = sourceX >= destinationX would be OK.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:111
> +        destination = destinationBegin + (frameWidth * startHeight);

What about putting (frameWidth * startHeight) into another variable ?

> Source/WebKit/efl/ewk/ewk_view_single.cpp:167
> +    int copyHeight = scrollHeight - abs(scrollRequest->dy);

Check whether you can reduce any repetition of same code ?

> Source/WebKit/efl/ewk/ewk_view_single.cpp:172
> +    verticalUpdate.w = scrollWidth - copyWidth;

You can reuse scrollRequest->dx for this.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:179
> +    horizontalUpdate.h = scrollHeight - copyHeight;

You can reuse scrollRequest->dy for this.
What about moving both two Eina_Rectangle block into line 183 ?
And why do you have to use Eina_Rectangle for the temporal usage ?

> Source/WebKit/efl/ewk/ewk_view_single.cpp:181
> +    if (destinationX != sourceX || destinationY != sourceY)

if you have to check the condition, scrollRequest->dx and dy may be used instead of this line.

> Source/WebKit/efl/ewk/ewk_view_single.cpp:190
> +    evas_object_image_data_update_add(smartData->backing_store, scrollX, scrollY, scrollWidth, scrollHeight);

May be, all visible area seems dirty according to implementation.
Would you double check update area ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.