[Webkit-unassigned] [Bug 74993] [EFL] Refactor the way using cairo in ewk_tiled_backing_store.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74993





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2011-12-27 01:03:58 PST ---
(From update of attachment 120570)
View in context: https://bugs.webkit.org/attachment.cgi?id=120570&action=review

> Source/WebKit/efl/ewk/ewk_tiled_model.cpp:249
>      if (colorSpace == EVAS_COLORSPACE_ARGB8888) {
>          bytes = area * 4;
> -        stride = width * 4;
> -        format = CAIRO_FORMAT_ARGB32;
>      } else if (colorSpace == EVAS_COLORSPACE_RGB565_A5P) {
>          bytes = area * 2;
> -        stride = width * 2;
> -        format = CAIRO_FORMAT_RGB16_565;
>      } else {

remove brace for one statement.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:31
>  
> +#include <RefPtrCairo.h>

please fix order and remove empty line.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:45
> +    Eina_Bool ret = false;
> +
> +    RefPtr<cairo_t> cairo;
> +    RefPtr<cairo_surface_t> surface;
> +    int stride;
> +    cairo_format_t format;
> +    cairo_status_t status;

IMO, C++ can declare variable when it is required.

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:76
> +    ret = ewk_view_paint_contents(priv, cairo.get(), &rect);
>  
> -    return ewk_view_paint_contents(priv, tile->cairo, &rect);
> +    return ret;

ret is not necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.