[Webkit-unassigned] [Bug 75238] Enable DOWNLOAD_ATTRIBUTE in blackberry porting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75238





--- Comment #3 from Leo Yang <leo.yang at torchmobile.com.cn>  2011-12-26 22:50:30 PST ---
(From update of attachment 120567)
View in context: https://bugs.webkit.org/attachment.cgi?id=120567&action=review

Informal review.

> ChangeLog:3
> +        Enable DOWNLOAD_ATTRIBUTE in blackberry porting

blackberry --> the BlackBerry? Also bug title?

> Tools/ChangeLog:3
> +        Enable DOWNLOAD_ATTRIBUTE in blackberry porting

blackberry --> the BlackBerry? Also bug title?

> Tools/Scripts/build-webkit:86
>      $directoryUploadSupport,
> +    $downloadSupport,

downloadSupport --> downloadAttributeSupport?

> Tools/Scripts/build-webkit:143
> +    { option => "download-attribute", desc => "Toggle download attribute support",
> +      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadSupport },

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.