[Webkit-unassigned] [Bug 74179] [EFL] Context menu restore for WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74179





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-12-26 02:34:03 PST ---
(In reply to comment #14)
> (From update of attachment 120448 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120448&action=review
> 
> > Source/JavaScriptCore/wtf/Platform.h:1078
> > +#if PLATFORM(WIN) || PLATFORM(EFL)
> 
> Almost good for me.
> 
> could you remove -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1 from Source/WebCore/PlatformEfl.cmake ?

EFL WK1 is enabling CROSS_PLATFORM_CONTEXT_MENU. But, EFL WK2 is not using CROSS_PLATFORM_MENU. As discussed in private channel, Michal will support CROSS_PLATFORM_CONTEXT_MENU on EFL WebKit2.

Why don't we disable CROSS_PLATFORM_CONTEXT_MENU when we build EFL WebKit2 until Michal fix it ?  

If CORSS_PLATFORM_CONTEXT_MENUS is turned off, I remember there were build errors during the WebKit EFL port building.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.