[Webkit-unassigned] [Bug 45228] window.scrollBy() scrolls incorrectly when zoomed in/out

Fri Dec 23 18:50:21 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=45228

--- Comment #20 from Jarred Nicholls <jarred at webkit.org>  2011-12-23 18:50:20 PST ---
(From update of attachment 119045)
View in context: https://bugs.webkit.org/attachment.cgi?id=119045&action=review

I would also have a test that changes both zoom and scale factor at once.

> LayoutTests/fast/dom/scroll-scaled-page-test.html:7
> +<script>

Hoist the script up into <head>

> LayoutTests/fast/dom/scroll-scaled-page-test.html:10
> +        if (window.layoutTestController) {

fast & http tests are preferred to use the test harness code in LayoutTests/fast/js/resources/.  You should include js-test-pre.js before your test script and js-test-post.js after your test script, and utilize the test functions.  See http://trac.webkit.org/browser/trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html for an example test that uses this harness code.

> LayoutTests/fast/dom/scroll-scaled-page-test.html:19
> +            window.scrollBy(0, x)

missing semi-colon (it's "legit" but we should keep it clean)

> LayoutTests/fast/dom/scroll-scaled-page-test.html:25
> +                resultString += " PASS - " + "The window scrolls by " + offset + "px when the scale factor is applied"    ;

Lots of whitespace in front of the semi-colon

> LayoutTests/fast/dom/scroll-scaled-page-test.html:34
> +<body onload="testScroll()";>

runaway semi-colon

> LayoutTests/fast/dom/scroll-scaled-page-test.html:36
> +</body>

No </html>?

> LayoutTests/fast/dom/zoom-scroll-page-test.html:7
> +<script>

hoist up

> LayoutTests/fast/dom/zoom-scroll-page-test.html:16
> +            window.scrollBy(0, x)

semi-colon

> LayoutTests/fast/dom/zoom-scroll-page-test.html:31
> +<body onload="testScroll()";>

runaway semi-colon

> LayoutTests/fast/dom/zoom-scroll-page-test.html:34
> +

</html>

> Source/WebCore/ChangeLog:11
> +        The relative scroll distance must take the zoom factor into account.

It's better to put the description up higher, under the bug title & url.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.