[Webkit-unassigned] [Bug 75097] Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75097





--- Comment #2 from Sam Weinig <sam at webkit.org>  2011-12-23 14:54:32 PST ---
(From update of attachment 120355)
View in context: https://bugs.webkit.org/attachment.cgi?id=120355&action=review

> Source/WebCore/ChangeLog:3
> +        Need a function to expose m_visuallyNoEmptyCharacterCount in FrameView. 

I think you mean m_visuallyNonEmptyCharacterCount.

> Source/WebCore/ChangeLog:16
> +        the page is already visually no empty.  The value is reset at FrameView::reset().

Typo. no -> non.

> Source/WebCore/page/FrameView.h:-507
> +    m_visuallyNonEmptyCharacterCount += count;
>      if (m_isVisuallyNonEmpty)
>          return;
> -    m_visuallyNonEmptyCharacterCount += count;

If we are incrementing this count even after becoming visually non-empty, I am not sure the variable name makes sense any more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.