[Webkit-unassigned] [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 23 13:00:12 PST 2011


Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #118807|0                           |1
        is obsolete|                            |
 Attachment #118807|review?, commit-queue?      |
               Flag|                            |

--- Comment #13 from Zan Dobersek <zandobersek at gmail.com>  2011-12-23 13:00:12 PST ---
Created an attachment (id=120476)
 --> (https://bugs.webkit.org/attachment.cgi?id=120476&action=review)
WIP Patch

This is just a WIP patch on which I'd like some comments.

I've introduced a new macro, TOP_LEVEL_DIR, in Tools/GNUmakefile.am. It is later used in DumpRenderTree.cpp as a return value when calling getTopLevelPath. Also in that function, if environment variable WEBKIT_TOP_LEVEL is not set, it is set to the value of the TOP_LEVEL_DIR macro.

This nullifies the need of setting the WEBKIT_TOP_LEVEL variable in testing environment, so this is not done anymore in the GtkPort in webkitpy.

In ImageGtk.cpp, resource is loaded from the checkout tree if WEBKIT_TOP_LEVEL is set (now only if DumpRenderTree is run) or from DATA_DIR otherwise. Smart pointer is not used at this moment as I believe there's no need for it based on the path acquiring that is used in this patch.

This patch leaves the resource loading on Windows platform pretty broken. I'm not able to test the changes for this platform, so the best I can do is a blind guess at how things should be handled.

I'd like to hear some comments on this patch and especially the Windows issue, and because this patch is more of a WIP/RFC, I'm not setting any flags on this patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list