[Webkit-unassigned] [Bug 61862] EventSource should support CORS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 14:43:19 PST 2011


--- Comment #38 from Alexey Proskuryakov <ap at webkit.org>  2011-12-22 14:43:18 PST ---
> didFailAccessControlCheck will only be called when CORS is used so it's good that there's a default/empty implementation for it. 

Understood why it cannot be "= 0". I don't understand why it's good for it to be empty. 

> I used an ASSERT_NOT_REACHED() here to test that didFailAccessControlCheck is implemented wherever it's needed, but then I removed it

I would still prefer a compile time guarantee. Would it be a mistake to fall back to didFail()?

> I wonder how this can be done without making ResourceError aware of web platform concepts like CORS.

Yes, you're right. This wasn't a good idea. This still feels quite messy (e.g. CORS will be doing redirect checks too, so why is there a separate callback with a different signature for didFailRedirectCheck?)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list