[Webkit-unassigned] [Bug 74260] SnowLeopard crashes due to thread-unsafe EventListenerIterator ASSERTs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74260





--- Comment #8 from Andreas Kling <kling at webkit.org>  2011-12-22 09:21:13 PST ---
(In reply to comment #7)
> (From update of attachment 120328 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120328&action=review
> 
> > Source/WebCore/dom/EventListenerMap.h:85
> > +#ifdef NDEBUG
> > +    void assertNoActiveIterators() { }
> > +#else
> > +    void assertNoActiveIterators();
> 
> Sometimes I like to put the declaration in unconditionally and put the inline empty implementation outside the class definition.
> 
> > Source/WebCore/dom/EventListenerMap.h:87
> > +    Mutex m_activeIteratorCountMutex;
> 
> Since this is for assertion purposes only, we could consider just sharing one global mutex rather than having a separate one for each map. That could keep down the number of #if statements in the header.

Great suggestions, will revise!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.