[Webkit-unassigned] [Bug 61541] Port W3C audio and video tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61541





--- Comment #6 from Joel Parks <joel.parks at nokia.com>  2011-12-22 08:00:13 PST ---
I agree this is fantastic, but it seems to me that some latent errors in the W3C test content were ported along with the good stuff.

A good number of the audio tests[*] are apparently copy-pasted from video tests without changing the video element to audio element.  There are separate tests in the video section for audio media in video elements, which helps convince me that it's a copy-paste error.

Also, as Eric Carlson mentions, it would be good to point out that the options parameter is not being respected by the new wrapper.  However, my experience is that the original harness does not respect attempts to modify the timeout, so perhaps this is a moot point!  I wasn't able to take the time to investigate the cause of that behavior.

(In reply to comment #3)
> (From update of attachment 94993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94993&action=review
> 
> Thanks, this is fantastic! 
> 
...snip...
> 
> I see that the "options" parameter is ignored. It looks like 'timeout' is currently the only parameter, which I assume we can ignore because of DRT's own timeout, but it is probably worth adding a comment to that effect and throwing an exception if any other option is passed in case future tests add other options.


[*] This is a list of the audio tests (and expected results files) that contain video elements instead of audio elements:

LayoutTests/media/W3C/audio/events/event_canplay-expected.txt
LayoutTests/media/W3C/audio/events/event_canplay.html
LayoutTests/media/W3C/audio/events/event_canplay_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_canplay_manual.html
LayoutTests/media/W3C/audio/events/event_canplaythrough-expected.txt
LayoutTests/media/W3C/audio/events/event_canplaythrough.html
LayoutTests/media/W3C/audio/events/event_canplaythrough_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_canplaythrough_manual.html
LayoutTests/media/W3C/audio/events/event_loadeddata-expected.txt
LayoutTests/media/W3C/audio/events/event_loadeddata.html
LayoutTests/media/W3C/audio/events/event_loadeddata_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_loadeddata_manual.html
LayoutTests/media/W3C/audio/events/event_loadedmetadata-expected.txt
LayoutTests/media/W3C/audio/events/event_loadedmetadata.html
LayoutTests/media/W3C/audio/events/event_loadedmetadata_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_loadedmetadata_manual.html
LayoutTests/media/W3C/audio/events/event_loadstart-expected.txt
LayoutTests/media/W3C/audio/events/event_loadstart.html
LayoutTests/media/W3C/audio/events/event_loadstart_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_loadstart_manual.html
LayoutTests/media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt
LayoutTests/media/W3C/audio/events/event_order_canplay_canplaythrough.html
LayoutTests/media/W3C/audio/events/event_order_canplay_playing-expected.txt
LayoutTests/media/W3C/audio/events/event_order_canplay_playing.html
LayoutTests/media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt
LayoutTests/media/W3C/audio/events/event_order_loadedmetadata_loadeddata.html
LayoutTests/media/W3C/audio/events/event_order_loadstart_progress-expected.txt
LayoutTests/media/W3C/audio/events/event_order_loadstart_progress.html
LayoutTests/media/W3C/audio/events/event_pause_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_pause_manual.html
LayoutTests/media/W3C/audio/events/event_play-expected.txt
LayoutTests/media/W3C/audio/events/event_play.html
LayoutTests/media/W3C/audio/events/event_play_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_play_manual.html
LayoutTests/media/W3C/audio/events/event_playing-expected.txt
LayoutTests/media/W3C/audio/events/event_playing.html
LayoutTests/media/W3C/audio/events/event_playing_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_playing_manual.html
LayoutTests/media/W3C/audio/events/event_progress-expected.txt
LayoutTests/media/W3C/audio/events/event_progress.html
LayoutTests/media/W3C/audio/events/event_progress_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_progress_manual.html
LayoutTests/media/W3C/audio/events/event_timeupdate-expected.txt
LayoutTests/media/W3C/audio/events/event_timeupdate.html
LayoutTests/media/W3C/audio/events/event_timeupdate_manual-expected.txt
LayoutTests/media/W3C/audio/events/event_timeupdate_manual.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.