[Webkit-unassigned] [Bug 61862] EventSource should support CORS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61862


Per-Erik Brodin <per-erik.brodin at ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111298|0                           |1
        is obsolete|                            |
 Attachment #120316|                            |review?
               Flag|                            |




--- Comment #32 from Per-Erik Brodin <per-erik.brodin at ericsson.com>  2011-12-22 06:18:33 PST ---
Created an attachment (id=120316)
 --> (https://bugs.webkit.org/attachment.cgi?id=120316&action=review)
patch 5

> (From update of attachment 111298 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111298&action=review
> 
> Looks like the spec changed substantially since the patch was posted.
> 
> > Source/WebCore/page/EventSource.cpp:119
> >      options.allowCredentials = AllowStoredCredentials;
> 
> The spec says that credentials should not be sent cross-origin unless constructor is called with a second argument telling it to allow credentials:

Fixed.

> There should also be a readonly withCredentials attribute on EventSource object.

Fixed.

> > Source/WebCore/page/EventSource.cpp:256
> > +    bool failedResourceSharingCheck = error.domain() == errorDomainWebKitInternal;
> 
> That's terribly fragile. We need a better way to communicate this to EventSource code.

Yes, that doesn't even work anymore since now errorDomainWebKitInternal is used for other error conditions as well.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.