[Webkit-unassigned] [Bug 73773] [WK2][GTK] WebSettings support in MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73773





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-12-22 04:12:32 PST ---
(In reply to comment #8)
> (From update of attachment 117791 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117791&action=review
> 
> >> Tools/MiniBrowser/gtk/main.c:87
> >> +        if (value && g_ascii_strcasecmp(value, "true") && strcmp(value, "1"))
> > 
> > I don't undertand this line g_ascii_strcasecmp(value, "true") && strcmp(value, "1"), I don't know what the intention is, but the value can't be "true" and "1".
> 
> IIUC, this tests if value != true and value != 1

right!, I always forget !strcmp(a,b) mean a == b :-P that's why I always use == 0, but it's not allowed by webkit coding style, so nevermind, sorry for the noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.