[Webkit-unassigned] [Bug 74842] SSE optimization for FFTFrameFFMPEG.cpp::multiply()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74842





--- Comment #11 from Chris Rogers <crogers at google.com>  2011-12-21 20:35:52 PST ---
(From update of attachment 120259)
View in context: https://bugs.webkit.org/attachment.cgi?id=120259&action=review

> Source/WebCore/platform/audio/VectorMath.cpp:79
> +#else

You need to invoke ::zvmul exactly with the same arguments as vDSP_zvmul()

and move lines 77:79 down to just after line 88

In other words ::zvmul() also needs to take DSPSplitComplex arguments (as opposed to our new VectorMath::zvmul() function...)

> Source/WebCore/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:122
>      float scale = 0.5f;

Please move lines 121:122 to just before first use, which is now just before line 134

> Source/WebCore/platform/audio/mac/FFTFrameMac.cpp:113
>      float scale = 0.5f;

Please move lines 112:113 to just right before first use, which is now just before line 126

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.