[Webkit-unassigned] [Bug 74955] WebKit adds vertical paddings and borders to the fixed width of CSS tables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74955





--- Comment #5 from Max Vujovic <mvujovic at adobe.com>  2011-12-21 15:23:55 PST ---
Thanks for the review, Julien!

> > LayoutTests/fast/table/script-tests/css-table-width.js:3
> > +description(
> > +"This test checks that the width style is applied correctly to CSS tables with respect to table paddings and borders."
> > +);
> 
> You can put that on one line.

Sounds good.

> I would love to see some examples with a vertical writing mode (like 'writing-mode: vertical-rl') and some values of 'text-orientation' / 'direction' as this test feels not sufficient. Also a vertical writing mode would have shown the issue pretty easily (just put some padding in the inline base direction but not in the block flow direction).

Very good idea- I'll craft some more tests and reupload a patch.

> > Source/WebCore/rendering/RenderTable.cpp:233
> > +        LayoutUnit bordersAndPadding = 0;
> 
> I am not too fond of the naming. You don't include the paddings if you are on a collapsing border CSS table.
> 
> I couldn't find anything better (my take was bordersAndPaddingsOnNonCollapsingBordersTable which is too long). The variable name should at least be bordersAndPaddings for consistency.

Good point. Both "borders" and "bordersAndPaddings" aren't entirely right, but "borders" sounds better. I'll change it back to "borders" :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.