[Webkit-unassigned] [Bug 74807] It should be possible to change the value of an Options variable without recompiling the world

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74807





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2011-12-21 14:41:52 PST ---
(In reply to comment #4)
> Hi Filip,
> 
> Was this a simple reversion of bug 72938?

Yes, it was.

> 
> Do you have any more specific feedback for me?

JavaScriptCore is not meant to be used on the command-line, but rather, as a framework. Often the only practical way to change a heuristic is to recompile.  And if I have to do that, then I don't want to have to recompile the whole world.

Hence why Options variables were originally defined in a C++ file as out-of-line constants.

While I like your change, since it reduces code duplication, it means that to change an Options value I have to edit Options.h, which is included in a bunch of places, causing nearly a world-recompile.  This is especially annoying when I'm debugging, profiling, and optimizing WebKit.

-F

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.