[Webkit-unassigned] [Bug 74890] Web Inspector: CodeGeneratorInspector.py: generate anonymous types.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 21 01:01:31 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=74890





--- Comment #6 from Yury Semikhatsky <yurys at chromium.org>  2011-12-21 01:01:30 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 119923 [details] [details])
> > Looks good. What does it do?
> 
> Let me describe it here a bit more.
> 
> In general it generates now C++ type for anonymous object types from JSON. It takes a name from the type declaration site, usually a parameter name. This all is explained comments in generated file. Also all generated types now refer to other generated types in setter methods — but this is commented out in generated code for now. All necessary forward declarations are also added. Anonymous enums are also generated, but they are in comments too, because we didn't have solution about form the enums should have in C++ API.
> 
> Internally:
> The change reorganizes type bindings — a polymorphous "code generator" object is factored out from binding.
> A helper class Writer is added to allow generating code with ajustable indentations and to support insertion points where additional code can be inserted retroactively.
> ForwardListener class is used for preparing necessary forward declarations.
> AdHocTypeContext conception is a speculative abstract class that is needed wherever anonymous type can emerge.

This is a good message to be placed into the ChangeLog entry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list