[Webkit-unassigned] [Bug 72584] Support Image Level 3's image() notation; it offers automated image flipping for RTL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 20 21:23:57 PST 2011


--- Comment #12 from Tim Horton <timothy_horton at apple.com>  2011-12-20 21:23:55 PST ---
(From update of attachment 120084)
View in context: https://bugs.webkit.org/attachment.cgi?id=120084&action=review

> Source/WebCore/css/CSSImageFallbackValue.cpp:59
> +    UNUSED_PARAM(renderer);

You can, if you want, leave off the argument name above, and remove UNUSED_PARAM.

>> Source/WebCore/css/CSSImageFallbackValue.h:70
>> +    String customCssText() const;
> s/Css/CSS/.

That would be inconsistent with the other CSSImageGeneratorValue subclasses. Perhaps they should all be changed?

>> Source/WebCore/css/CSSImageFallbackValue.h:71
>> +    PassRefPtr<Image> image(RenderObject*, const IntSize&);
> If this function just finds an image (as opposed to creating it), raw pointer seems preferable.

At least in the pure color case, it'll be creating a Generator subclass (I assume, I've vaguely talked to Matt about this), and returning a new GeneratorGeneratedImage here.

>> Source/WebCore/css/CSSParser.cpp:35
>>  #include "CSSCursorImageValue.h"
> Please maintain alphabetic order. I'm surprised that style bot isn't yelling.

Yeah, that's pretty bizarre. It's yelled at me before on numerous occasions.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list